Deanna EarleyAdminDeanna Earley (Admin, Inno Setup)

  1. 5 votes
    Vote 0 votes Vote Vote
    Vote
    Sign in
    Check!
    (thinking…)
    Reset
    or sign in with
    • facebook
    • google
      Password icon
      I agree to the terms of service

      You'll receive a confirmation email with a link to create a password (optional).

      Signed in as (Sign out)
      You have left! (?) (thinking…)
      Deanna EarleyAdminDeanna Earley (Admin, Inno Setup) gave this 1 vote  · 
      Deanna EarleyAdminDeanna Earley (Admin, Inno Setup) commented  · 

      As the install and uninstall executables are the same, the only thing you can do to make it easier is to add a second icon to the executable, meaning you don't have to distribute a separate .ico file and you can just set IconIndex on the shortcut to 2. It's arguable whether this is worth it or not to save one file on disk.
      It does make sense (IMO) to have a default 2nd icon embedded so we dont need to distribute one explicitly for the uninstall shortcut.

    • 2 votes
      Vote 0 votes Vote Vote
      Vote
      Sign in
      Check!
      (thinking…)
      Reset
      or sign in with
      • facebook
      • google
        Password icon
        I agree to the terms of service

        You'll receive a confirmation email with a link to create a password (optional).

        Signed in as (Sign out)
        You have left! (?) (thinking…)
        Deanna EarleyAdminDeanna Earley (Admin, Inno Setup) gave this 1 vote  · 
      • 7 votes
        Vote 0 votes Vote Vote
        Vote
        Sign in
        Check!
        (thinking…)
        Reset
        or sign in with
        • facebook
        • google
          Password icon
          I agree to the terms of service

          You'll receive a confirmation email with a link to create a password (optional).

          Signed in as (Sign out)
          You have left! (?) (thinking…)
          Deanna EarleyAdminDeanna Earley (Admin, Inno Setup) gave this 1 vote  · 
        • 7 votes
          Vote 0 votes Vote Vote
          Vote
          Sign in
          Check!
          (thinking…)
          Reset
          or sign in with
          • facebook
          • google
            Password icon
            I agree to the terms of service

            You'll receive a confirmation email with a link to create a password (optional).

            Signed in as (Sign out)
            You have left! (?) (thinking…)
            Deanna EarleyAdminDeanna Earley (Admin, Inno Setup) shared this idea and gave it 2 votes  · 
          • 121 votes
            Vote 0 votes Vote Vote
            Vote
            Sign in
            Check!
            (thinking…)
            Reset
            or sign in with
            • facebook
            • google
              Password icon
              I agree to the terms of service

              You'll receive a confirmation email with a link to create a password (optional).

              Signed in as (Sign out)
              You have left! (?) (thinking…)
              Deanna EarleyAdminDeanna Earley (Admin, Inno Setup) commented  · 

              Features don't exist by default...
              Someone has to spend time designing, coding and testing them.

              I think the phrase is "all patches welcome" :o)

              Deanna EarleyAdminDeanna Earley (Admin, Inno Setup) gave this 1 vote  · 
            • 36 votes
              Vote 0 votes Vote Vote
              Vote
              Sign in
              Check!
              (thinking…)
              Reset
              or sign in with
              • facebook
              • google
                Password icon
                I agree to the terms of service

                You'll receive a confirmation email with a link to create a password (optional).

                Signed in as (Sign out)
                You have left! (?) (thinking…)
                Deanna EarleyAdminDeanna Earley (Admin, Inno Setup) gave this 1 vote  · 
              • 34 votes
                Vote 0 votes Vote Vote
                Vote
                Sign in
                Check!
                (thinking…)
                Reset
                or sign in with
                • facebook
                • google
                  Password icon
                  I agree to the terms of service

                  You'll receive a confirmation email with a link to create a password (optional).

                  Signed in as (Sign out)
                  You have left! (?) (thinking…)
                  Deanna EarleyAdminDeanna Earley (Admin, Inno Setup) gave this 1 vote  · 
                • 10 votes
                  Vote 0 votes Vote Vote
                  Vote
                  Sign in
                  Check!
                  (thinking…)
                  Reset
                  or sign in with
                  • facebook
                  • google
                    Password icon
                    I agree to the terms of service

                    You'll receive a confirmation email with a link to create a password (optional).

                    Signed in as (Sign out)
                    You have left! (?) (thinking…)
                    Deanna EarleyAdminDeanna Earley (Admin, Inno Setup) gave this 1 vote  · 
                    Deanna EarleyAdminDeanna Earley (Admin, Inno Setup) commented  · 

                    There are function to do almost everything else so this one makes sense to me.

                  • 53 votes
                    Vote 0 votes Vote Vote
                    Vote
                    Sign in
                    Check!
                    (thinking…)
                    Reset
                    or sign in with
                    • facebook
                    • google
                      Password icon
                      I agree to the terms of service

                      You'll receive a confirmation email with a link to create a password (optional).

                      Signed in as (Sign out)
                      You have left! (?) (thinking…)
                      declined  ·  Martijn LaanAdminMartijn Laan (Admin, Inno Setup) responded

                      Closing this since it’s not viable for many reasons, some outlined earlier. If you voted for this to be able to ask the user questions during uninstall, vote on the uninstall wizard pages request instead.

                      Deanna EarleyAdminDeanna Earley (Admin, Inno Setup) commented  · 

                      Custom wizard pages are unrelated as I said I don't think this can be used properly for interactive checks.
                      The example I gave in the original post is still valid (and yes, they can still be done in [Code], but I think this is tidier)

                      Deanna EarleyAdminDeanna Earley (Admin, Inno Setup) gave this 2 votes  · 
                      Deanna EarleyAdminDeanna Earley (Admin, Inno Setup) commented  · 

                      IMO, No it shouldn't for the reasons I stated.
                      Furthermore, the rollback could have been triggered because of a problem which means that the code can't run as expected.

                      If you aren't happy with that, you could pass a "IsRollingBack" parameter to the function and let the code determine what it wants to do.

                      Deanna EarleyAdminDeanna Earley (Admin, Inno Setup) commented  · 

                      The point of the rolling back is to return it as close to the same state as when it started because it was cancelled or something went wrong. This means undoing everything it did (unconditionally).

                      The uninstall is different and would be more intelligent as there is much more chance of something having happened that needs special attention.

                      Deanna EarleyAdminDeanna Earley (Admin, Inno Setup) shared this idea  · 
                    • 19 votes
                      Vote 0 votes Vote Vote
                      Vote
                      Sign in
                      Check!
                      (thinking…)
                      Reset
                      or sign in with
                      • facebook
                      • google
                        Password icon
                        I agree to the terms of service

                        You'll receive a confirmation email with a link to create a password (optional).

                        Signed in as (Sign out)
                        You have left! (?) (thinking…)
                        Deanna EarleyAdminDeanna Earley (Admin, Inno Setup) gave this 1 vote  · 
                      • 6 votes
                        Vote 0 votes Vote Vote
                        Vote
                        Sign in
                        Check!
                        (thinking…)
                        Reset
                        or sign in with
                        • facebook
                        • google
                          Password icon
                          I agree to the terms of service

                          You'll receive a confirmation email with a link to create a password (optional).

                          Signed in as (Sign out)
                          You have left! (?) (thinking…)
                          completed  ·  Martijn LaanAdminMartijn Laan (Admin, Inno Setup) responded

                          From CVS:

                          The PrivilegesRequired [Setup] section directive can now be set to lowest. On Windows Vista and later this instructs Setup to not request elevated rights (via a User Account Control dialog) even if it was started by a member of the Administrators group. Do not use this setting unless you are sure your installation will run successfully on unprivileged accounts. On Windows NT/2000/XP/2003, lowest behaves the same as none.

                          Deanna EarleyAdminDeanna Earley (Admin, Inno Setup) commented  · 

                          I understand that this will allow user specific installs (uninstall keys in HKCU) on vista as an admin, but will all other windows versions will still forcibly run as a global install into HKLM if it can?

                          Deanna EarleyAdminDeanna Earley (Admin, Inno Setup) commented  · 

                          Maybe an option to force the install to be "per user".
                          This would disable the elevation for admin users and (if enabled) write the uninstall entries to HKCU.

                          Deanna EarleyAdminDeanna Earley (Admin, Inno Setup) gave this 1 vote  · 
                        • 163 votes
                          Vote 0 votes Vote Vote
                          Vote
                          Sign in
                          Check!
                          (thinking…)
                          Reset
                          or sign in with
                          • facebook
                          • google
                            Password icon
                            I agree to the terms of service

                            You'll receive a confirmation email with a link to create a password (optional).

                            Signed in as (Sign out)
                            You have left! (?) (thinking…)
                            Deanna EarleyAdminDeanna Earley (Admin, Inno Setup) gave this 2 votes  · 
                          • 11 votes
                            Vote 0 votes Vote Vote
                            Vote
                            Sign in
                            Check!
                            (thinking…)
                            Reset
                            or sign in with
                            • facebook
                            • google
                              Password icon
                              I agree to the terms of service

                              You'll receive a confirmation email with a link to create a password (optional).

                              Signed in as (Sign out)
                              You have left! (?) (thinking…)
                              Deanna EarleyAdminDeanna Earley (Admin, Inno Setup) gave this 1 vote  · 

                            Knowledge Base and Helpdesk